Conversation
|
Other version specific resources define a |
Co-authored-by: Toby Brain <tobio85@gmail.com>
|
A note from testing to deal with later: I restarted the stack, but still had some terraform state laying around. When I tried to do an apply, I got the following: A 404 is expected here since obviously that SLO is gone with the restart, but wondering if the provider should be smart enough to recreate it or just fail like this? I feel like at least the error message should be a bit more specific? |
The resource should be treating this error as if the resource no longer exists and needs to be recreated. |
…-236-add-slo-pr-2
|
@wandergeek , please update |
|
@wandergeek , thanks for the contribution 👍 |
Yep, good idea. One thing I'm grappling with right now is whether to point the URL to Curious what you think here. I've pointed it to main for now. |
…-236-add-slo-pr-2
I guess we can follow the same approach as for alerting. |
This is what I'd like to do, but not all changes I want are in 8.9. I guess I could just point it at 8.10 even though its unreleased. One thought that I had today was it'd be cool to somehow store/tag what sha the generated client is using, so when it gets updated, you can easily see what changed since the last update. |
|
Ok, just pushed a mammoth update to this. I've broken up the indicators into their own subtypes as you suggested to work around the SDKv2 limitations. There's still a little clean up work to do, but thought I'd share so you could have a look overnight (if you have time). |
|
@wandergeek , it looks good 👍 |
Co-authored-by: Toby Brain <tobio85@gmail.com>
Overview
This PR adds kibana SLO management capabilities to the provider.
Testing
The custom metrics and histogram indicators are only supported in >8.10, so you will need to launch latest and greatest stack. I've been using kibana to do this:
Launch ES
Launch KB
Run tests